Merged
Conversation
NullVoxPopuli
commented
Mar 17, 2026
| @@ -37,89 +38,81 @@ export function ember(params?: { | |||
| async config(config: UserConfig, env: ConfigEnv) { | |||
Collaborator
Author
There was a problem hiding this comment.
some of this was reorganized so I had an easier time narrowing types with the above hasRolldown fn
NullVoxPopuli
commented
Mar 17, 2026
| "rolldown-vite": "^7.2.10", | ||
| "rollup": "^4.53.3", | ||
| "vite": "^7.2.6", | ||
| "rolldown": "1.0.0-rc.9", |
Collaborator
Author
There was a problem hiding this comment.
kinda silly this is the latest release, but we're just using it for types
ef4
approved these changes
Mar 17, 2026
void-mAlex
reviewed
Mar 18, 2026
void-mAlex
reviewed
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of note, vite8's types are not compatible with rollup's types.
This is probably due to silly TS / instance / private field reasons