Require Vite 6 #2211
Draft
Require Vite 6 #2211
+136
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
reviewed
Dec 16, 2024
| @@ -10,7 +10,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@embroider/core": "workspace:^", | |||
| "vite": "^5.2.0" | |||
| "vite": "^6.0.3" | |||
There was a problem hiding this comment.
Shouldn't we allow both versions?
There was a problem hiding this comment.
Is there an advantage to keeping v5 support?
There was a problem hiding this comment.
counter point: is there any need to drop support for 5 🤷 We should be expanding the range because we don't have any functionality that requires v6
There was a problem hiding this comment.
did we have a feature planned that required the new environments stuff?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't want to see this message in the terminal anymore:
WARN Issues with peer dependencies found # ... └─┬ @embroider/vite 0.2.1-unstable.c51ca2b └── ✕ unmet peer vite@^5.2.0: found 6.0.3This is a breaking change, but it's no biggy, really.