Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sourcemaps for GJS #2162

Open
wants to merge 6 commits into
base: stable
Choose a base branch
from
Open

Fix sourcemaps for GJS #2162

wants to merge 6 commits into from
+32 −9

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Nov 2, 2024 •
edited
Loading

Using @embroider/[email protected], I noticed this message:

(!) Broken sourcemap
https://rollupjs.org/troubleshooting/#warning-sourcemap-is-likely-to-be-incorrect
Plugins that transform code (such as "rollup-gjs-plugin") should generate accompanying sourcemaps.

This PR fixes that

This PR enables viewing actual gts and gjs in the browser, as original source

image

image
image

and most importantly, breakpoints line up:
image

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Nov 2, 2024
@NullVoxPopuli NullVoxPopuli mentioned this pull request Nov 5, 2024
Merged
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review November 5, 2024 15:24
@NullVoxPopuli NullVoxPopuli mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricklx patricklx patricklx left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @patricklx