Optimize implicit-modules graph #2161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `implicit-modules` backward compatibility feature is implemented by a graph of virtual modules, one per addon, where each addon's virtual module imports the virtual modules from its addon dependencies. This works well because it allows every implicit module to get imported from the right place in the package graph. But many addons don't need this feature, so you end up with many empty modules. This causes unnecessary network requests in development. We can optimize by looking ahead recursively and not emitting imports for modules that won't have anything in them. This prunes back the graph to the minimum size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
implicit-modulesbackward compatibility feature is implemented by a graph of virtual modules, one per addon, where each addon's virtual module imports the virtual modules from its addon dependencies. This works well because it allows every implicit module to get imported from the right place in the package graph.But many addons don't need this feature, so you end up with many empty modules. This causes unnecessary network requests in development.
We can optimize by looking ahead recursively and not emitting imports for modules that won't have anything in them. This prunes back the graph to the minimum size.