Add test for library export coditions #2097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news:
mains usage of Vite appropriately handles export conditions!And so does the stable branch!: #2098
I'm trying to figure out why we're shipping the Dev version of the VM in production app builds, and this PR is exploring if we're losing export-condition compatibility somewhere.
See also:
vendor.jsgrows by 52 KB in production minified build in 5.6.0 compared to 5.5.0 emberjs/ember.js#20628Of note, where I've been testing this is old embroider/webpack, so it's possible that, by using vite, all our problems will go away.
From Ed in Discord:
So, the my whole hypothesis about using glimmer-vm's export conditions is out the window.
Idk if it makes sense to keep the tests though.