vite deps: correctly handle addon templates and addon app files 2

[patricklx]

• makes external templates ignored
• optimised templates do not get a pairing
• hbs extension search during bundle
• externalize app files during bundling
  • since the request comes from a dep file we cannot know the original addon file. Which is why the from file will be encoded into the specifier.
  • This is required because the resolution can change during development
• stage2 tests now correctly uses optmized deps

[patricklx]

@ef4 this fixes some esbuild issues .
It sometimes fails on windows though

[patricklx]

@ef4 I tried to move the extension resolving here to defaultResolve, but it does not work.
I think the issue is that when we resolve files in addons, we do use a relative specifier with a from file in the rewritten-addons. What esbuild then sees is something like

{
   type: 'ignored',
   result: {
    external: true,
    path: './components/hello-world'
  }
}

so it has relative path as the externalized ID, I think this will confuse the system between esbuild and vite

[patricklx]

I did the same changes in #1876 and there it works

[patricklx]

I think we could do this as an intermediate step? I would change the tests to do the checks at runtime

[ef4]

Thanks for working on the stage2 tests here, I actually tried to use your version in #2093 but realized there was just so much irrelevant stuff lurking in that test suite that it needed rewriting anyway, and I was able to drop a lot of it.

[ef4]

I would suggest merging master and adding tests to the vite-internals tests, which I have now expanded so they run against vite dev and see the effects of the dep optimizer.

[patricklx]

this looks like its fixed, closing