Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember standard modules to include @ember/renderer and @ember/-internals and ember-testing #2075

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Aug 23, 2024

Ran in to this over on @ember/test-helpers v4 -- emberjs/ember-test-helpers@0631b49

We have an escape hatch for addons to use, but these modules should probably be defined here.

Docs:

@NullVoxPopuli NullVoxPopuli changed the title Update ember standard modules to include @ember/renderer and @ember/-internals Update ember standard modules to include @ember/renderer and @ember/-internals and ember-testing Aug 27, 2024
@mkszepp
Copy link
Contributor

mkszepp commented Aug 28, 2024

After adding in ember-power-select (and also ember-power-calendar) the peerDependency ember/test-helpers v4 we are running into the error:
Error: Could not find module @ember/renderer imported from ember-power-select/test-support

The error is only present in old ember versions (3.28 and 4.4...) everything else looks fine...

pipeline 3.28: https://github.com/cibernox/ember-power-select/actions/runs/10590872677/job/29347390528?pr=1848#step:6:115
pipeline 4.4: https://github.com/cibernox/ember-power-select/actions/runs/10590872677/job/29347390717?pr=1848#step:6:87

  • For 3.28 i have set in ember-try 2.9.4 (as it the official last version which supports 3.x) => i don't understand why we can get now the error after updating test-helpers...
  • For 4.4 i'm using latest test helper as its official supported...

The addons (and also the app) is forcing ^4.0.2 of test-helpers

Maybe our issue is related and fixed with this PR.

I don't like to add @ember/renderer... in addon as external package as we don't use it directly, but this is maybe atm the only fix...

Hope we can get this fix otherwise we can't allow test-helpers v4 for the addons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants