Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure reproduction: add test for @ember/string @ 4 #2068

Closed
wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Aug 21, 2024

Based on errors I'm seeing related to ember-cli-deprecation-workflow, I have a hunch that something is related to implicit modules.

In ember-cli/ember-cli-deprecation-workflow#194 we think that @ember/string should be able to be removed from ember-cli-deprecation-workflow entirely, as it's not imported anywhere.
(Update: tests seem to agree: ember-cli/ember-cli-deprecation-workflow#197 )


We do try to account for real @ember/string here: https://github.com/embroider-build/embroider/blob/main/packages/shared-internals/src/ember-standard-modules.ts#L26-L27

@NullVoxPopuli
Copy link
Collaborator Author

NullVoxPopuli commented Aug 21, 2024

The types of errors:

Module not found: Error: 
  ember-cli-app-version is trying to import the app's @ember/string package, 
  but it seems to be missing

and

Could not find module `@ember/string` 
  imported from `(require)` at http://localhost:7357/assets/vendor.js, line 253\

🤔

@NullVoxPopuli NullVoxPopuli changed the title Add test for @ember/string @ 4 Failure reproduction: add test for @ember/string @ 4 Aug 21, 2024
@NullVoxPopuli NullVoxPopuli deleted the add-test-for-@ember-string-4 branch August 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant