Failure reproduction: add test for @ember/string @ 4 #2068
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on errors I'm seeing related to ember-cli-deprecation-workflow, I have a hunch that something is related to implicit modules.
In ember-cli/ember-cli-deprecation-workflow#194 we think that
@ember/string
should be able to be removed from ember-cli-deprecation-workflow entirely, as it's not imported anywhere.(Update: tests seem to agree: ember-cli/ember-cli-deprecation-workflow#197 )
We do try to account for real
@ember/string
here: https://github.com/embroider-build/embroider/blob/main/packages/shared-internals/src/ember-standard-modules.ts#L26-L27