Revert "Add just the necessary files to rollup watch mode" #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vstefanovic97 can you check if this would still fix your issue? |
patricklx
changed the title
patricklx
force-pushed
the
revert-2007-watch-only-necessary-files
branch
from
711df01
to
a8549f7
Compare
patricklx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2007
this was not correct, now its not detecting new added files. This means rollup will not include any new files in the entrypoint.
I think the right solution would have been to either setup watch exlcude or watch include
https://rollupjs.org/configuration-options/#watch-exclude
and was giving me a headache why #1855 was suddenly failing after merging stable...