unique-id helper import based on ember-source version #2005

void-mAlex · 2024-06-22T13:54:32Z

matched by semver ranges

packages/compat/src/resolver-transform.ts

mansona

This looks great, the fact that we have a test covering the behaviour means I really don't think we should delay getting this merged 👍

void-mAlex added 4 commits June 22, 2024 13:33

find ember source version of a particular app/engine

90e515b

declare required param

c9e5151

compute built ins based on current ember-source version

6414375

matched by semver ranges

add tests for unique-id helper

a333b32

void-mAlex requested a review from a team June 22, 2024 13:56

void-mAlex added the bug Something isn't working label Jun 22, 2024

void-mAlex changed the title ~~Bugfix unique id version import~~ unique id import based on ember-source version Jun 22, 2024

void-mAlex changed the title ~~unique id import based on ember-source version~~ unique-id helper import based on ember-source version Jun 22, 2024

mansona reviewed Jun 24, 2024

View reviewed changes

packages/compat/src/resolver-transform.ts Show resolved Hide resolved

mansona approved these changes Jun 24, 2024

View reviewed changes

mansona merged commit 356ad20 into stable Jun 24, 2024
203 checks passed

mansona deleted the bugfix-unique-id-version-import branch June 24, 2024 13:16

github-actions bot mentioned this pull request Jun 24, 2024

Prepare Release #2001

Merged

Provide feedback