Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript and fix issues with Typescript 5.5 #2000

Merged
merged 3 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"scripts": {
"clean": "git clean -x -f",
"compile": "tsc",
"dev": "tsc -b --watch",
"lint": "concurrently 'npm:lint:*(!fix)' --names 'lint:'",
"lint:fix": "concurrently 'npm:lint:*:fix' --names 'fix:'",
"lint:eslint": "eslint . --cache --report-unused-disable-directives",
Expand Down Expand Up @@ -50,7 +51,7 @@
"jest": "^29.2.1",
"prettier": "^2.3.1",
"release-plan": "^0.9.0",
"typescript": "^5.1.6"
"typescript": "^5.5.2"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand All @@ -67,4 +68,4 @@
},
"wildcardLabel": "unlabeled"
}
}
}
7 changes: 4 additions & 3 deletions packages/shared-internals/src/rewritten-package-cache.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import PackageCache from './package-cache';
import type { V2AddonPackage, V2AppPackage, V2Package } from './package';
import Package from './package';
import { existsSync, readJSONSync, realpathSync } from 'fs-extra';
import { resolve } from 'path';
Expand Down Expand Up @@ -240,15 +241,15 @@ class WrappedPackage implements PackageTheGoodParts {
return this.plainPkg.isLazyEngine();
}

isV2Ember() {
isV2Ember(): this is V2Package {
return this.plainPkg.isV2Ember();
}

isV2App() {
isV2App(): this is V2AppPackage {
return this.plainPkg.isV2App();
}

isV2Addon() {
isV2Addon(): this is V2AddonPackage {
return this.plainPkg.isV2Addon();
}

Expand Down
89 changes: 63 additions & 26 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading