remove the ember-addon keyword from rewritten app #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ef4 This is the work that we sketched out together. It turns out that we're breaking public API with this change 🤔 https://github.com/embroider-build/ember-auto-import/blob/main/packages/ember-auto-import/ts/webpack.ts#L432 That's not the worst thing of course but I would have to undo your change to override shared internals for this monorepo so that ember-auto-import always got its own version (that matches the semver range). Any objection? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is splitting off the first part of #1936 to make it easier to review and get merged 👍