Output _babel_filter_.js in the .embroider folder
#1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r folder so it's separated from the rewritten-app
BlueCutOfficial
changed the title
_babel_filter_.js in the .embroider folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1935
Context
We are still working on removing the rewritten app completely. To achieve this goal, we need to remove all the remaining differences between the initial Ember app and the rewritten app generated at stage 2.
One of these differences is the presence of
_babel_filter_.jsin the root folder of the rewritten-app._babel_filter_.jsis related to theskipBabeloption and howember-cli-babelworks. It's something we don't want to keep in the new Embroider + Vite world because we don't wantember-cli-babelto be a requirement and the Babel config should be standard and defined in the user's Ember app. So the ultimate goal is to remove_babel_filter_.js.This PR
This PR should be seen as an intermediate step.
Even though we want to remove the
skipBabeloption and_babel_filter_.js, here, we simply move the file out of the rewritten app, and we now output it directly in the.embroiderfolder, which contains all the config files we need.The point of this intermediate step is to unblock the removal of the rewritten app and manage the deletion of
skipBabelas a separated topic, independent from the deactivation of the rewritten app.