Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@embroider/macros and type=module #1906

Draft
wants to merge 10 commits into
base: stable
Choose a base branch
from
Draft

@embroider/macros and type=module #1906

wants to merge 10 commits into from

Commits on May 7, 2024

  1. make addon a module 

    Addon-main is cjs, it should have cjs extension

Reproduction success

Make separate scenario

Test file must end with -test

Need to update the app's ember-cli-babel

Test is passing, now let's break it again...

Break successful
    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    361439c View commit details
    Browse the repository at this point in the history

  2. Reduce test to just es-compat resolving

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    345dfc6 View commit details
    Browse the repository at this point in the history

  3. Passes (incorrectly)

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f716780 View commit details
    Browse the repository at this point in the history

  4. fails (correctly)

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b315076 View commit details
    Browse the repository at this point in the history

  5. Minimal test, pre fix

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c63f5d5 View commit details
    Browse the repository at this point in the history

  6. lint:fix

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c93b19c View commit details
    Browse the repository at this point in the history

  7. Reduce diff from origin/stable

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    09dbe55 View commit details
    Browse the repository at this point in the history

  8. The fix

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3b16269 View commit details
    Browse the repository at this point in the history

  9. addon-main MUST be cjs

    @NullVoxPopuli
    NullVoxPopuli committed May 7, 2024
    Configuration menu
    Copy the full SHA
    abdf30c View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. use maybeEmbroider

    @NullVoxPopuli
    NullVoxPopuli committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1e33544 View commit details
    Browse the repository at this point in the history