-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre support in portable babel launcher #1885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 💪
Merged
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Apr 22, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
May 15, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
May 16, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
May 16, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
May 16, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
May 21, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
May 22, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Jun 13, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Jun 20, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Jun 24, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Jul 31, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Aug 21, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Aug 28, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Aug 28, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Sep 12, 2024
…-babel-launcher Fix pre support in portable babel launcher
patricklx
pushed a commit
to patricklx/embroider
that referenced
this pull request
Sep 12, 2024
…-babel-launcher Fix pre support in portable babel launcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portable-babel-launcher that we use to deal with plugin serializability didn't correctly handle options in pre hooks. babel-plugin-ember-template-compilation just released with a change that needs to handle options in the pre hook.