Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre support in portable babel launcher #1885

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Apr 18, 2024

The portable-babel-launcher that we use to deal with plugin serializability didn't correctly handle options in pre hooks. babel-plugin-ember-template-compilation just released with a change that needs to handle options in the pre hook.

@ef4 ef4 added the bug Something isn't working label Apr 18, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 💪

@ef4 ef4 merged commit 2636437 into stable Apr 18, 2024
201 checks passed
@ef4 ef4 deleted the portable-babel-launcher branch April 18, 2024 14:02
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
patricklx pushed a commit to patricklx/embroider that referenced this pull request Apr 22, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request May 15, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request May 16, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request May 16, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request May 16, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request May 21, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request May 22, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Jun 13, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Jun 20, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Jun 24, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Jul 31, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Aug 21, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Aug 28, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Aug 28, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Sep 12, 2024
…-babel-launcher

Fix pre support in portable babel launcher
patricklx pushed a commit to patricklx/embroider that referenced this pull request Sep 12, 2024
…-babel-launcher

Fix pre support in portable babel launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants