merge default options and the prebuild options provided in ember-cli-build #1837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the
prebuild
function has been written in thedefault-pipeline
so we can run the build with Vite requirements by default:However, there was an issue with the way
prebuild
uses the options: If an options object was provided inember-cli-build.js
, this would replace entirely thedefaultPrebuildOptions
that Vite requires and options likestaticAddonTrees
andstaticEmberSource
would befalse
instead oftrue
, resulting to breaking side effects.This PR changes
prebuild
function to always use thedefaultPrebuildOptions
and extend them with the passed options.How to test manually
tests/vite-app/ember-cli-build.js
, do the following change: