Update to ember-cli-babel v8
#1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
update-to-ember-cli-babel-v8
branch
from
54192d3
to
bc01419
Compare
mansona
approved these changes
Mar 4, 2024
Merged
|
It turns out that this should have been a breaking change 😞 the only reason this was working for the most part was because the dependencies of ember-cli-babel weren't using any dependencies that would break tests. Recently babel-plugin-module-resolver bumped their glob major version (in a patch 😫) that brought in minimatch@8 which needs at least Node 14 (for private fields) tleunen/babel-plugin-module-resolver#445 @embroider/util is being used by ember-auto-import tests that need to work in Node 12 so we should have made this a major 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.