Fix source map option not being passed to plugin #1787
Conversation
packages/addon-dev/src/rollup.ts
Outdated
| @@ -57,8 +57,8 @@ export class Addon { | |||
| return hbs(); | |||
| } | |||
|
|
|||
| gjs() { | |||
| return gjs(); | |||
| gjs(options: { inline_source_map: true }) { | |||
There was a problem hiding this comment.
@vstefanovic97 shouldn’t we mark this as optional?
| gjs(options: { inline_source_map: true }) { | |
| gjs(options?: { inline_source_map: true }) { |
There was a problem hiding this comment.
🤦♂️ , I'll fix it right away
| gjs() { | ||
| return gjs(); | ||
| gjs(options?: { inline_source_map: true }) { | ||
| return gjs(options); |
There was a problem hiding this comment.
Is there any downside to defaulting this to true?
We already have rollup's sourcemaps enabled
There was a problem hiding this comment.
hmm well probably not, I think I can default it to true in this case if you want @NullVoxPopuli
There was a problem hiding this comment.
I changed the default to true @NullVoxPopuli
There was a problem hiding this comment.
sorry for all of these tiny mistakes and having to do release patches.... my brain not working well these past 2 days 🤦♂️ , would have made another mistake if @SergeAstapov didn't catch it
There was a problem hiding this comment.
I mean, in your defense, we don't have sufficient testing for addon-dev in this repo
|
@NullVoxPopuli can we merge and release patch ? |
Sorry about that, checked and now it works 100%
Missed it in #1786 thought plugin was just getting re-exported, my mistake