fix publish for stable branch #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +49,7 @@ jobs: | |||
| registry-url: 'https://registry.npmjs.org' | |||
|
|
|||
| - name: npm publish | |||
| run: pnpm release-plan publish | |||
| run: pnpm release-plan publish --publish-branch=stable | |||
There was a problem hiding this comment.
don' we want --publish-branch=stable|main, since we merge stable into main frequently?
There was a problem hiding this comment.
once we sync this it won't be a problem any more. For example #1721 didn't even try to update the yaml branches
also it's better to be explicit with this.
and also we didn't test if that syntax works (if the pnpm docs says it does that's fine but I'm extra cautious around releasing things). We know what this PR has does work because I've done it manually twice.
So in summary, no i don't think we should change this 😂
There was a problem hiding this comment.
ah ok, I see what you mean
Legit
NullVoxPopuli
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we needed to update relase-plan to add an option
--publish-branchbecause by default pnpm only allows you to runpnpm publishon main or master. We are running it onstableand it was hanging in CI because it was prompting to know if you wanted to continue.This PR prevents that from happening again 👍