Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always load ember-testing package eagerly #1717

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Always load ember-testing package eagerly #1717

merged 1 commit into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. Always load ember-testing package eagerly 

    In ember-source 5.6 (now in beta), we refactored the way Ember and its test-only pieces find each other to no longer be dependent on the AMD loader.

But this mean it's no longer sufficient to `define()` *and not evaluate* the `ember-testing` package in order to install the test support. It must actually get evaluted first.

Note that this bug does not manifest on embroider `main`, because there implicit-test-modules are eagerly evaluated. This is only a problem on stable, when using `staticEmberSource: true`.
    @ef4
    ef4 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e5cb780 View commit details
    Browse the repository at this point in the history