Support engine's lazyLoading boolean config #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengb seems like CI is not happy with this change |
|
seems like the CI issue is not just impacting this PR, #1707 also has it |
fengb
force-pushed
the
lazyloading-boolean
branch
from
6adccc0
to
2e8dd81
Compare
void-mAlex
approved these changes
Dec 7, 2023
mansona
force-pushed
the
lazyloading-boolean
branch
from
2e8dd81
to
c4dcdf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine's lazyLoading previously used boolean configs
lazyLoading: true. This re-enables the backwards compatibility inside embroider.Source: https://github.com/ember-engines/ember-engines/blob/master/packages/ember-engines/lib/utils/ensure-lazy-loading-hash.js