Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #1703 to stable #1705

Conversation

chancancode
Copy link
Contributor

cherry picked from #1703 / commit a562b4e

Ran into bugs/issues with using polling mode when writing tests for embroider-build#1696, specifically that on my macOS dev environment using polling, when watching a directory it doesn't seem to consistently emit the `added` event.

Mainly I wanted to see which, if any, tests fail without this option. It also seemed a bit suspect since rollup/chokidar presumably works on windows out of the box?

Even if this is necessary we may want to limit it to the windows test only (can just set `CHOKIDAR_USEPOLLING` on the job level), since this makes things _less_ realistic everywhere else.

(cherry picked from commit a562b4e)
@void-mAlex void-mAlex merged commit 9ea9e87 into embroider-build:stable Dec 5, 2023
201 checks passed
@chancancode chancancode deleted the cherry-pick-a562b4e6cdc709909862bd7d79d899f55c8fda63 branch December 6, 2023 00:03
This was referenced Dec 6, 2023
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants