-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix single asterisk replacement in reverse-exports #1676
Conversation
I have found this in the documentation:
Also, the mention of
Thank you for the heads up, I know exactly how to fix it. |
Fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't "request changes" since it's my PR 🙃 one minor thing and one that I would like to fix before we merge 👍
df09d0a
to
77be472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @lolmaus! 😂
I took the reverse-exports package out for its first real-world spin today by combining #1648 #1650 and #1653 into one giant mega branch 💪 ... but it didn't work 😂
I first looked at the error and thought "on no we need to update the blueprint because the exports are wrong" but thinking about it a bit better it looks like our reverse-exports could do with a little bit of love. This is totally expected in the dev process of the package since real-world examples will always beat lab-built ones 👍
@lolmaus if you could take a look at this and get the test passing that would be super 🎉