fix node version for @embroider/util #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
approved these changes
Nov 9, 2023
void-mAlex
approved these changes
Nov 10, 2023
|
looks like 'genuine' windows test failures |
|
Yea it's not just failing in windows I'm afraid 😞 the issue with this package is that it's not actually possible (I think) to test it in isolation from an ember app 🤔 and we might have to so a bit of work to get tests passing for an Ember app in Node 12 😫 I'll take another look today 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while updating another ember app that
@embroider/utilaccidentally dropped support for Node 12 in a minor version so this just fixes that 👍