Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo of publicAssetURL #1646

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

camerondubas
Copy link
Contributor

Just noticed this example config didn't match the actual property name

@ef4
Copy link
Contributor

ef4 commented Oct 16, 2023

I think this is still incorrect because it's showing publicAssetURL inside webpackConfig. publicAssetURL is an option to @embroider/webpack not to webpack.

@camerondubas
Copy link
Contributor Author

I think this is still incorrect because it's showing publicAssetURL inside webpackConfig. publicAssetURL is an option to @embroider/webpack not to webpack.

ah, you're right! I updated the commit

@void-mAlex
Copy link
Collaborator

I wonder if this was not refering to https://webpack.js.org/configuration/output/#outputpublicpath instead which is very similar in function

@ef4
Copy link
Contributor

ef4 commented Oct 18, 2023

Yeah I wondered that too but I think the docs are better here if they show our publicAssetURL, not webpack's output.publicPath.

@ef4
Copy link
Contributor

ef4 commented Oct 18, 2023

Thanks!

@ef4 ef4 merged commit cd8d1be into embroider-build:main Oct 18, 2023
208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants