Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app-level watch-mode tests #1624

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Add app-level watch-mode tests #1624

merged 2 commits into from
Oct 6, 2023

Conversation

NullVoxPopuli
Copy link
Collaborator

Adds our first app-level watch-mode tests so we can start testing against some more involved scenarios that @chancancode has been fixing 🎉

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉

pnpm-lock.yaml Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oofta. I cannot win today


assert.false(await checkScripts(/js$/, content), 'file has not been created yet');

fs.writeFile(path.join(app.dir, 'app/simple-file.js'), `export const two = "${content}";`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we here await for file creation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess yes technically 😂 but we have a thing just after that that is explicitly looking for the "app rebuild" notification which only happens after the file is written so it's safe to not await here 👍

@mansona mansona merged commit cb4e47b into main Oct 6, 2023
202 checks passed
@mansona mansona deleted the watch-mode-tests branch October 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants