Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some action items to the peer errors when node_modules is messed up #1603

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Add some action items to the peer errors when node_modules is messed up #1603

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
163edb2
Add some action items -- resolves https://github.com/embroider-build/…
NullVoxPopuli Sep 15, 2023
5ac9de7
change title
NullVoxPopuli Sep 15, 2023
bfa0083
Update standalone-addon-build.ts
NullVoxPopuli Nov 7, 2023
4e7794a
Update standalone-addon-build.ts
NullVoxPopuli Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/compat/src/standalone-addon-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ export function convertLegacyAddons(compatApp: CompatApp) {
`Some V1 ember addons are resolving as incorrect peer dependencies. This makes it impossible for us to safely convert them to v2 format.
See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.

tl;dr: action items from the above documentation
- ensure your package-manager version is up to date
- delete all node_modules directories and re-install your dependencies
NullVoxPopuli marked this conversation as resolved.
Show resolved Hide resolved
- deduplicate dependencies (e.g.: pnpm dedupe)

${summarizePeerDepViolations(violations)}`
);
}
Expand Down