Fix relative import path of assets for non-entrypoint modules #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When modules reference static assets added to the build via the `keepAssets` rollup plugin, and those modules are not entrypoints and as such moved into a bundle at a different location, the relative path to that asset would not get rewritten, leading to broken references. Fixes embroider-build/addon-blueprint#192
NullVoxPopuli
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modules reference static assets added to the build via the
keepAssetsrollup plugin, and those modules are not entrypoints and as such moved into a bundle at a different location, the relative path to that asset would not get rewritten, leading to broken references.Fixes embroider-build/addon-blueprint#192
Successfully tested in a local project. We don't have unit tests for rollup plugins here. And I haven't found scenarios that implicitly test the behavior of
keepAssets, but maybe I missed that. Do we have an easy way to add tests, or is this good as-is?