Simplification of gjs and hbs handling in addon-dev #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplified the resolution of gjs and hbs files in addon-dev. No custom resolveId is needed. The rules are: - publicEntrypoints are always expressed in terms of JS, and those automatically get mapped to their underlying gjs or template-only-component hbs as needed - relative imports within the addon should use explicit extensions (keeping in mind that a template-only-component is always a ".js" extension, even when the js is automatically generated) - the babel config should explicitly handle extensions .hbs and .gjs. This should be released as breaking to document the need to adjust the babel extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplified the resolution of gjs and hbs files in addon-dev. No custom resolveId is needed. The rules are:
This should be released as breaking to document the need to adjust the babel extensions.