Initial test of vite integration #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which will make it easier to iterate. It can get extracted into a real test after.
When using importSyncImplementation:cjs, the amdModules are evaluated lazily, after the eager modules. When using importSyncImplementation:eager (which is needed for vite and any true ES module environment), everything is going to get evaluated in the order it is written here. So we should write the eager modules before the lazy ones.
| @@ -0,0 +1,5 @@ | |||
| export * from './src/resolver.js'; | |||
There was a problem hiding this comment.
Was this supposed to be comitted? 🙃
There was a problem hiding this comment.
Yes. This is working around the fact that our packages all compile to commonjs and the vite config is a real node ES module. Both the implementation and the types go through these top-level reexports, which happens to make the cjs interop work out ok.
There was a problem hiding this comment.
Someone please do the big yak shave to get all our packages dual compiling as CJS and ESM so I don't have to. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an automated test yet, just an app that you can run and the beginning of vite integrations to make it run.