Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat adapter to add re-export observer-manager service #1543

Conversation

void-mAlex
Copy link
Collaborator

fixes #1498 (solution 2 from #1498 (comment))

this pr fixes the problematic addon that uses a non standard way of injecting a service.
with this we get more compatibility when people turn on static flags without a big enhancement to detecting this edge case and automatically fixing it

@ef4 ef4 merged commit ed7b6fe into embroider-build:main Jul 18, 2023
196 checks passed
@ef4 ef4 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addon owned service with staticAddonTrees breaks DI
2 participants