Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate per-package implicit-modules imports #1536

Merged
merged 5 commits into from
Jul 16, 2023
Merged

Generate per-package implicit-modules imports #1536

merged 5 commits into from
Jul 16, 2023

Commits on Jul 15, 2023

  1. Generate per-package implicit-modules imports 

    Previously, all implicit-modules got imported by their containing engine (normally the app). This makes some sense, because they are getting AMD-defined into one flat namespace anyway for compatibility reasons. If there are multiple versions of a package in the transitive deps, only one can be present in the AMD loader.

However, this assumes there will be resolvability from the app all the way to the transitive deps, which is not reliably true. And it also means that if there is a mismatch between the list of implicit-modules provided by different copies of a package you could run into failures where you try to find them in the wrong copy.

So instead, this PR moves the importing of implicit modules into per-package virtual modules. Each package imports its own direct dependencies' implicit modules, as well as the virtual implicit-module entrypoints for those dependencies, so the system recurses.
    @ef4
    ef4 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    7d2f862 View commit details
    Browse the repository at this point in the history

  2. attempting to fix matching on windows

    @ef4
    ef4 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    28315be View commit details
    Browse the repository at this point in the history

  3. updating tests

    @ef4
    ef4 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    8c94dcb View commit details
    Browse the repository at this point in the history

  4. fixing type error

    @ef4
    ef4 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    cad4542 View commit details
    Browse the repository at this point in the history

  5. updating another test

    @ef4
    ef4 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    5811386 View commit details
    Browse the repository at this point in the history