Restore older node support #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@embroider/shared-internals` is used by ember-auto-import, and ember-auto-import intentionally has a very wide support policy that includes node 12.
NullVoxPopuli
approved these changes
Jul 12, 2023
void-mAlex
approved these changes
Jul 12, 2023
Comment on lines
48
to
49
| let nodebin = tryit.output.trim(); | ||
| let result = await app.execute(`${nodebin} ./node_modules/.bin/qunit ./test.js`); |
There was a problem hiding this comment.
consider my mind blown
There was a problem hiding this comment.
Volta is pretty good at keeping you inside its little fence. Need to be tricky if you actually want to get out like this.
There was a problem hiding this comment.
Maybe there's actually real Volta public API for doing this in a way that doesn't need tricks...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@embroider/shared-internalsis used by ember-auto-import, and ember-auto-import intentionally has a very wide support policy that includes node 12.