Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rollup-plugin-ts with @rollup/plugin-typescript #1510

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jul 2, 2023

rollup-plugin-ts tries to do too much and has issues. @rollup/plugin-typescript is in the official rollup org and supports a mode that only emits declarations while leaving the build to babel.

@ef4
Copy link
Contributor Author

ef4 commented Jul 2, 2023

Also, I want to upgrade to typescript 5 and rollup-plugin-ts is blocking us from doing that.

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Jul 2, 2023

I'll make the corresponding changes on the v2 addon blueprint 🎉

update: nevermind, I'm like. 90% sure @rollup/plugin-typescript can't work with gjs/gts, and 100% sure it can't work without configuring "transformers" -- https://github.com/rollup/plugins/tree/master/packages/typescript/#transformers -- but I don't think we have anything that speaks that API, as we "just" use the template-imports stuff everywhere atm

update2: this is fine tho, because we can run glint as a rollup plugin to generate the types

update3: opened embroider-build/addon-blueprint#135

@ef4
Copy link
Contributor Author

ef4 commented Jul 3, 2023

Yeah I know that the case on this PR so far -- our router package -- is a simple case because it doesn't have any components.

I agree that stand-alone glint for the declaration files is probably necessary.

@ef4 ef4 changed the title Replace rollup-plugin-ts with @rollup/plugin-typescript Replace rollup-plugin-ts with @rollup/plugin-typescript in router package Jul 3, 2023
@ef4 ef4 added the internal label Jul 3, 2023
@ef4 ef4 changed the title Replace rollup-plugin-ts with @rollup/plugin-typescript in router package Replace rollup-plugin-ts with @rollup/plugin-typescript Jul 3, 2023
@ef4 ef4 merged commit a1b2971 into main Jul 3, 2023
@ef4 ef4 deleted the rollup-plugin-ts branch July 3, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants