Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less aggressive realpathSync #1503

Merged
merged 1 commit into from
Jul 1, 2023
Merged

less aggressive realpathSync #1503

merged 1 commit into from
Jul 1, 2023

Commits on Jul 1, 2023

  1. less aggressive realpathSync 

    The realpath checks were added because in some environments node_modules is symlinked and we need to account for that. But they also mean that if any directory that appears in the index isn't present it can cause a crash, and that can indeed happen when output from a previous build is still present and hasn't been updated yet.

This should hopefully achieve both goals by only resolving the top-level workingDir, and that only after proving that it's present.

Not doing realpath on every individual inner directory is OK because we control those.
    @ef4
    ef4 committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    0db95e2 View commit details
    Browse the repository at this point in the history