Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make proxied rewritten-package-cache methods clearer #1494

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Make proxied rewritten-package-cache methods clearer #1494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/shared-internals/src/rewritten-package-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,28 +232,28 @@ class WrappedPackage implements PackageTheGoodParts {
return this.plainPkg.meta;
}

get isEmberPackage() {
return this.plainPkg.isEmberPackage;
isEmberPackage() {
return this.plainPkg.isEmberPackage();
}

isEngine() {
return this.plainPkg.isEngine();
}

get isLazyEngine() {
return this.plainPkg.isLazyEngine;
isLazyEngine() {
return this.plainPkg.isLazyEngine();
}

get isV2Ember() {
return this.plainPkg.isV2Ember;
isV2Ember() {
return this.plainPkg.isV2Ember();
}

get isV2App() {
return this.plainPkg.isV2App;
isV2App() {
return this.plainPkg.isV2App();
}

get isV2Addon() {
return this.plainPkg.isV2Addon;
isV2Addon() {
return this.plainPkg.isV2Addon();
}

// it's important that we're calling this.dependencies here at this level, not
Expand Down