Properly serialize options #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.options` can contain arbitrary unserializable data (such as Broccoli trees, Webpack plugins, etc). Fixes #1441
NullVoxPopuli
approved these changes
Jun 28, 2023
|
To answer the question in the original PR: we could try to avoid regressing on this by adding some non-serializable webpack config to one of the existing app scenarios. That would be a nice followup but I don't consider it blocking to merge this. |
|
Thanks! I tried figuring out how to allow maintainer edits but the help article wasn't that helpful. I think it was because the fork was owned by an org? I'll send it from a personal fork next time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved merge conflicts in #1478, which wasn't set to be editable, hence this separate PR.