macroCondition: do branch elimination if no runtime impl. is involved #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make `macroCondition()` do full branch elimination even in development, as long as no macro is involved that has a runtime implementation (`get*Config()`, `isTesting` have). Closes #582
simonihmig
commented
Jun 8, 2023
| applyMode(config); | ||
| config.finalize(); | ||
| }); | ||
|
|
||
| buildTimeTest('if selects consequent, drops alternate', () => { | ||
| test('if selects consequent, drops alternate', () => { |
There was a problem hiding this comment.
Note how a lot of these buildTimeTest were turned into regular test to make them run in both modes, given that when no runtime macro is involved, they should just behave the same!
| @@ -401,11 +402,11 @@ describe('macroCondition', function () { | |||
| expect(code).not.toMatch(/alpha/); | |||
| }); | |||
|
|
|||
| runTimeTest('can be used as class field initializer', () => { | |||
| runTimeTest('given runtime implementation, it can be used as class field initializer', () => { | |||
There was a problem hiding this comment.
is there a runtime test exercising the possible outcomes of just isTesting?
There was a problem hiding this comment.
Yeah, there is something already here
NullVoxPopuli
approved these changes
Jun 9, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make
macroCondition()do full branch elimination even in development, as long as no macro is involved that has a runtime implementation (get*Config(),isTestinghave).Closes embroider-build/ember-auto-import#582