Refactor scenario helpers to a shared location #1454
Conversation
|
|
||
| return fixtureStructure; | ||
| } | ||
| export * from './helpers/index'; |
There was a problem hiding this comment.
at some point in node's history, implicit index is no longer available to use? I'd seen this in my ESM-node projects 🤷 anyone know why this has happened? did node folks decide that implicit index isn't a good idea? is it a configuration issue?
This file now emulates that behavior (and mostly to avoid having to change all the scenario tests to use ./helpers/index)
There was a problem hiding this comment.
I don't think this is a node thing in this context 😂 I'm pretty sure this whole import * and export * is a typescript specific thing that is pretty annoying if you ask me since it messes with true ESM semantics
There was a problem hiding this comment.
also I'm pretty sure that ESM wants you to always do file-based imports anyway because realistically you can't do the "is this a file or is this a folder with an index in it" logic all that efficiently on the web
NullVoxPopuli
changed the title
…f a file (this happened mostly because v2 addon watch infra is large, and we don't want its responsibilities mingling with the other helpers -- no code changes have been made -- only function moves Update relative directory reference since fixtures helpers are now in a directory
NullVoxPopuli
force-pushed
the
refactor-helpers
branch
from
177b34f
to
f19c012
Compare
this happened mostly because v2 addon watch infra is large, and we don't want its responsibilities mingling with the other helpers.
Aside from changing a relative path reference to having an extra
.., there are no code changes.This should help out @void-mAlex with some addon-dev testing / watching tests