Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Set output.experimentalMinChunkSize to 0, to counter a change in [email protected] #1449

Merged
merged 3 commits into from
May 26, 2023
Merged

[bugfix] Set output.experimentalMinChunkSize to 0, to counter a change in [email protected] #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7aa450b
chore: Alphabetized keys
ijlee2 May 25, 2023
09fbb18
chore: Set output.experimentalMinChunkSize so that (possibly) rollup-…
ijlee2 May 25, 2023
544820f
chore: Updated rollup and rollup-plugin-ts to the latest version
ijlee2 May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/addon-dev/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@types/fs-extra": "^9.0.12",
"@types/minimatch": "^3.0.4",
"@types/yargs": "^17.0.3",
"rollup": "^2.58.0",
"rollup": "^3.23.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/rollup/rollup/releases/tag/v3.0.0 for breaking changes that might affect @embroider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli Can you run CI for me?

"tmp": "^0.1.0",
"typescript": "^4.9.0"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/addon-dev/src/rollup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@ export class Addon {
output() {
return {
dir: this.#destDir,
format: 'es',
entryFileNames: '[name]',
experimentalMinChunkSize: 0,
format: 'es',
Comment on lines +78 to +79
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I alphabetized the keys. When there is a list of configuration keys, people tend to add a new one to the end of the list. I find unsorted lists not easy to understand and maintain.

hoistTransitiveImports: false,
sourcemap: true,
};
Expand Down
4 changes: 2 additions & 2 deletions packages/router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.0.0",
"prettier": "^2.5.1",
"rollup": "^2.67.0",
"rollup": "^3.23.0",
"rollup-plugin-copy": "^3.4.0",
"rollup-plugin-ts": "~3.0.2",
"rollup-plugin-ts": "^3.2.0",
"typescript": "^4.9.0"
},
"peerDependencies": {
Expand Down
Loading