-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linkto routable engine path in host app #1443
Conversation
…spoke forks but still check the same functionality applies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with what I see in this PR 👍 the only thing I'm not sure about is the use_lockfile: true
change. I understand the reasoning for the change and I'm happy to merge it, I just want us to be clear on a longer-term strategy as a team i.e. next steps
not intending to have that merged at all, but can't check CI for anything else right now as I don't know how to fix TS without that |
this pr adds a failing test case for routable lazy engines