Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent double ^ when using embroider test-setup #1436

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented May 18, 2023

After the last release @embroider/test-setup was outputting a double ^ for the embroider versions like this:

"@embroider/core": "^^3.0.0",
"@embroider/webpack": "^^3.0.0",
"@embroider/compat": "^^3.0.0"

I don't know if any other packagers are more lenient about this but pnpm is very unhappy, so we should remove the extra carat 👍

@mansona mansona added the bug Something isn't working label May 18, 2023
@mansona mansona merged commit abc3e4d into main May 18, 2023
@mansona mansona deleted the fix-test-setup branch May 18, 2023 16:10
@backspace
Copy link
Contributor

Thanks for fixing this, I was puzzled seeing ERR_PNPM_SPEC_NOT_SUPPORTED_BY_ANY_RESOLVER in CI because of the ^^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants