Release infra #1431
Merged
Release infra #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts our release infra back to being more similar to when we were using release-it, except with custom code to solve the non-lockstep version bumps problem. Like that setup, much of the actual work is driven by lerna-changelog.
While this is not yet plugged into GitHub actions, I designed these commands so they have a logical split to run as two GitHub actions workflows: one would do
embroider-release prepareand push that as a PR. The second would see that a new.release-plan.jsonwas merged to main and runembroider-release publish.