upgrade typescript #1421
Merged
upgrade typescript #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All our stuff actually typechecked -- the first try! -- under typescript 5.04 as well. But rollup-plugin-ts doesn't support it, and when I tried to use a different typescript only in the package that needs that (`@embroider/router`) pnpm did the wrong thing with peerDeps so it didn't actually work. So 4.9.0 is newer-enough for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All our stuff actually typechecked -- the first try! -- under typescript 5.04 as well. But rollup-plugin-ts doesn't support it, and when I tried to use a different typescript only in the package that needs that (
@embroider/router) pnpm did the wrong thing with peerDeps so it didn't actually get a different version there. So 4.9.0 is newer-enough for now.