Use a custom changelog line generator function to avoid adding meaningless changelog entries #1409
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| 'use strict'; | ||
|
|
||
| /** | ||
| * Modified version of | ||
| * https://github.com/changesets/changesets/blob/main/packages/changelog-git/src/index.ts | ||
| * | ||
| * This is because we do not add changelog entries per-PR (upon merge), and we instead add them | ||
| * later, (per changeset-recover, https://github.com/nullvoxpopuli/changeset-recover) | ||
| * | ||
| * All of the built-in changelog line generators provided by changesets assume a | ||
| * "add changeset before merge" workflow, and add git/github references accordingly. | ||
| * | ||
| * Here, we ignore the commit, and just use the changeset summary. | ||
| * | ||
| * See docs here: https://github.com/changesets/changesets/blob/main/docs/modifying-changelog-format.md | ||
| */ | ||
| async function getReleaseLine(changeset, _type) { | ||
| let [firstLine, ...futureLines] = changeset.summary.split('\n').map(l => l.trimRight()); | ||
|
|
||
| let returnVal = firstLine; | ||
|
|
||
| if (futureLines.length > 0) { | ||
| returnVal += `\n${futureLines.map(l => ` ${l}`).join('\n')}`; | ||
| } | ||
|
|
||
| return returnVal; | ||
| } | ||
|
|
||
| async function getDependencyReleaseLine(changesets, dependenciesUpdated) { | ||
| if (dependenciesUpdated.length === 0) return ''; | ||
|
|
||
| let changesetLinks = [`- Updated dependencies`]; | ||
| let updatedDependenciesList = dependenciesUpdated.map( | ||
| dependency => ` - ${dependency.name}@${dependency.newVersion}` | ||
| ); | ||
|
|
||
| return [...changesetLinks, ...updatedDependenciesList].join('\n'); | ||
| } | ||
|
|
||
| module.exports = { | ||
| getReleaseLine, | ||
| getDependencyReleaseLine, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json", | ||
| "changelog": "./changelog.cjs", | ||
| "commit": false, | ||
| "fixed": [["@embroider/compat", "@embroider/core", "@embroider/test-setup", "@embroider/webpack"]], | ||
| "access": "public", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused