continue deploying unstable packages even with an error #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the previous runs of NPM Publish for the unstable packages actually errored: https://github.com/embroider-build/embroider/actions/runs/4610016561/jobs/8147947998
In this case, the logical thing to do would be to rerun the process, but that wouldn't work if the release finished somewhere in the middle of the process because it would fail to deploy the first package again (because that version already exists).
This PR changes the semantics of the deploy step for unstable and it no longer stops on the first error it encounters. This means that we will be able to re-run the process without any issue if we have strange API problems again 👍