Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change namespace for publish-unstable cancel-in-progress #1390

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Change namespace for publish-unstable cancel-in-progress #1390

merged 1 commit into from
Mar 31, 2023

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Mar 31, 2023 •
edited
Loading

This decouples publish-unstable.yml cancel-in-progress from that in ci.yml, which would prevent spurious cancellations like this.

@backspace
Change namespace for cancel-in-progress
1a97f8e 
This decouples publish-unstable.yml cancel-in-progress
from that in ci.yml.
@backspace backspace changed the title Change namespace for cancel-in-progress Change namespace for publish-unstable cancel-in-progress Mar 31, 2023
NullVoxPopuli
NullVoxPopuli approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!!
accidental oversight!
(though I would have expected merge commits to keep the concurrency different from PRs 🙈 )

@backspace
Copy link
Contributor Author

ya I think concurrency is an all-repository namespace, I guess the event type would have to be part of the name for that to work 😯

@ef4 ef4 merged commit 72d5a8e into embroider-build:main Mar 31, 2023
@ef4
Copy link
Contributor

ef4 commented Mar 31, 2023

Thanks!

@ef4 ef4 added the internal label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@backspace @ef4 @NullVoxPopuli