Eliminate the need for node_modules rewriting #1374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have control over third-stage resolving, we should be able to route requests both to and from our rewritten v1-to-v2 addons without physically rewriting the node_modules tree. This will unblock running the true build tool directly against the project, rather than a temp reflection of the project.
The first commit here switches to a much-pared-down stage1 implementation. The next work is refactoring stage2 so that all addon discovery goes through our module-resolver and adding the features in module-resolver that handle inbound and outbound module requests for the rewritten addons.