Improve types of ensure-safe-component helper
#1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the Glint type of
ensure-safe-componentin two ways:when a component class is passed, the return type will not get narrowed down to an (mostly unusable)
ComponentLike<unknown>, but to the type of the passed component itselfFor more context see @dfreeman's comment here
when a string is passed that has an entry in the
@glint/environment-ember-loosetemplate registry, then the registered type will be returned instead of againComponentLike<unknown>Fixes typed-ember/glint#518
This has no test coverage here, as we don't have any type testing infrastructure set up. But I tested this locally in a Glint-enabled project using
yalc, and both changes seem to work fine!Would still love a review from either @dfreeman or @chriskrycho to be sure! 🙏