Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable release sync with main #1364

Merged

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Feb 17, 2023

TODO:

  • swap ember-apply to globby so that dev node can stay on node 14

Inspired by: https://github.com/ember-animation/ember-animated/blob/master/.github/workflows/publish-unstable.yml

CLI Output:

❯ node ./test-packages/unstable-release/version.js 
Setting version of packages/addon-dev
Setting version of packages/addon-shim
Setting version of packages/babel-loader-8
Setting version of packages/compat
Setting version of packages/core
Setting version of packages/hbs-loader
Setting version of packages/macros
Setting version of packages/router
Setting version of packages/shared-internals
Setting version of packages/test-setup
Setting version of packages/util
Setting version of packages/webpack
Updating dependencies of packages/addon-dev
Updating dependencies of packages/addon-shim
Updating dependencies of packages/babel-loader-8
Updating dependencies of packages/compat
Updating dependencies of packages/core
Updating dependencies of packages/hbs-loader
Updating dependencies of packages/macros
Updating dependencies of packages/router
Updating dependencies of packages/shared-internals
Updating dependencies of packages/test-setup
Updating dependencies of packages/util
Updating dependencies of packages/webpack

Sample Diff:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
• packages/addon-dev/package.json:1: 
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
│  1 │{                                                 │  1 │{
│  2 │  "name": "@embroider/addon-dev",                 │  2 │  "name": "@embroider/addon-dev",
│  3 │  "version": "3.0.0",                             │  3 │  "version": "3.0.0-unstable.331e133e",
│  4 │  "description": "Utilities for addon authors",   │  4 │  "description": "Utilities for addon authors",
│  5 │  "repository": {                                 │  5 │  "repository": {
│  6 │    "type": "git",                                │  6 │    "type": "git",

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
• packages/addon-dev/package.json:26: 
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
│ 26 │    "test": "jest"                                │ 26 │    "test": "jest"
│ 27 │  },                                              │ 27 │  },
│ 28 │  "dependencies": {                               │ 28 │  "dependencies": {
│ 29 │    "@embroider/core": "^2.0.0",                  │ 29 │    "@embroider/core": "2.1.1-unstable.331e133e",
│ 30 │    "@rollup/pluginutils": "^4.1.1",              │ 30 │    "@rollup/pluginutils": "^4.1.1",
│ 31 │    "assert-never": "^1.2.1",                     │ 31 │    "assert-never": "^1.2.1",
│ 32 │    "fs-extra": "^10.0.0",                        │ 32 │    "fs-extra": "^10.0.0",

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
• packages/addon-shim/package.json:1: 
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
│  1 │{                                                 │  1 │{
│  2 │  "name": "@embroider/addon-shim",                │  2 │  "name": "@embroider/addon-shim",
│  3 │  "version": "1.8.4",                             │  3 │  "version": "1.8.4-unstable.331e133e",
│  4 │  "description": "Make v2 addons work in non-Emb↴ │  4 │  "description": "Make v2 addons work in non-Emb↴
│    │                                  …roider apps.", │    │                                  …roider apps.",
│  5 │  "keywords": [],                                 │  5 │  "keywords": [],
│  6 │  "main": "./src/index.js",                       │  6 │  "main": "./src/index.js",

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
• packages/addon-shim/package.json:17: 
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
│ 17 │  },                                              │ 17 │  },
│ 18 │  "scripts": {},                                  │ 18 │  "scripts": {},
│ 19 │  "dependencies": {                               │ 19 │  "dependencies": {
│ 20 │    "@embroider/shared-internals": "^2.0.0",      │ 20 │    "@embroider/shared-internals": "2.0.0-unstab↴
│    │                                                  │    │                                   …le.331e133e",
│ 21 │    "broccoli-funnel": "^3.0.8",                  │ 21 │    "broccoli-funnel": "^3.0.8",
│ 22 │    "semver": "^7.3.8"                            │ 22 │    "semver": "^7.3.8"
│ 23 │  },                                              │ 23 │  },


@NullVoxPopuli NullVoxPopuli force-pushed the unstable-release-sync-with-main branch 3 times, most recently from cb40d9d to 9effdbd Compare February 17, 2023 21:31
package.json Outdated Show resolved Hide resolved
@@ -8959,6 +8959,21 @@ execa@^5.0.0, execa@^5.1.1:
signal-exit "^3.0.3"
strip-final-newline "^2.0.0"

execa@^7.0.0:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use new enough execa for execCommand / native ESM.

Node 14.18 is supported: https://github.com/sindresorhus/execa/blob/main/package.json#L16

@ef4
Copy link
Contributor

ef4 commented Mar 7, 2023

Publishing wasn't really implemented correctly but I fixed it and ran it locally. See the unstable.73213f2a packages on NPM.

@ef4 ef4 merged commit 21eae41 into embroider-build:main Mar 7, 2023
@ef4 ef4 added the internal label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants